Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry healthcheck with all available configs #33

Merged
merged 4 commits into from
Aug 6, 2024
Merged

retry healthcheck with all available configs #33

merged 4 commits into from
Aug 6, 2024

Conversation

elfkuzco
Copy link
Collaborator

@elfkuzco elfkuzco commented Aug 5, 2024

Changes

  • fetch all available configs before healthcheck. On startup, this is the list of all configs. For each test, it is the list of configs for the selected country.
  • add helper functions to perform healthcheck using list of configs till success
  • remove healthchecks from run method

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (512c059) to head (950f9b4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files          28       28           
  Lines         795      795           
  Branches       70       70           
=======================================
  Hits          579      579           
  Misses        204      204           
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elfkuzco elfkuzco requested a review from rgaudin August 5, 2024 14:30
@elfkuzco elfkuzco linked an issue Aug 5, 2024 that may be closed by this pull request
Worker network issue #32
Closed
rgaudin
rgaudin approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

worker/manager/src/mirrors_qa_manager/worker.py Outdated Show resolved Hide resolved
worker/manager/src/mirrors_qa_manager/worker.py Outdated Show resolved Hide resolved
worker/manager/src/mirrors_qa_manager/worker.py Outdated Show resolved Hide resolved
@rgaudin
Copy link
Member

rgaudin commented Aug 6, 2024

Oh crap didn't account for that ; let me fix it

@rgaudin rgaudin merged commit 115bfdb into main Aug 6, 2024
4 checks passed
@rgaudin rgaudin deleted the wg-retry-different-confs branch August 6, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker network issue
3 participants
@elfkuzco @codecov-commenter @rgaudin